About Club osCommerce

Showcasing osCommerce - the good, the bad and the ugly!

StumbleUpon It! DIGG It!

Gift Vouchers RC1 and RC2

Written By Gary on Feb 11 2008 ·

STOP PRESS: This contribution is now updated to Version 2 and supports Tax calculations. Please see the latest post about this.

-

Offering Gift Vouchers/Discounts is an excellent way to make sales, particularly on products where margins are high. A good example of this is "digital products" where (more than likely) margin is probably 100% of the sale amount.

By offering a 50% or more Discount Coupon, vendor is still making a good amount and the buyer has a bargain.

new client required the ability to offer Gift Vouchers and Discounts on the latest version of osCommerce which is called "RC1". After having a hunt through the Contributions area yesterday, I could not find anything that was suitable in terms of;

  • usable on RC1
  • easy to use for "not web savvy" person
  • coded cleanly

So, I went back to the drawing board and coded my own - based on some work I did years ago. With just a few lines of code I've now got a really nice Gift Vouchers package suitable for the latest version of osCommerce.

It's usable with RC1 and RC2 - I do have a MS2 version somewhere also. Anyone who wants it, please comment below and I will make time to turn it into a freely available contribution.

Added Screenshot showing Sort Orders (that work for me):


Buy Gary A Beer?
Buying me a "beer" helps me to keep my contributions updated and keep this blog alive. Cheers!


307 Comments

  1. Oh, when/if you comment, please let me know whether you require RC1 or RC2 or MS2 version. Thanks.

    Comment by Gary — February 11, 2008 @ 4:03 pm


  2. hi!!! thats exactly what i'm after!! your a legend!!! if at all possible i'd love this contribution… its exactly what i need :D GREAT JOB !!!!

    thanks again
    misery_kitty

    Comment by misery_kitty — February 12, 2008 @ 9:18 am


  3. oops forgot to mention i need the ms2 ;)

    Comment by misery_kitty — February 12, 2008 @ 9:19 am


  4. Sure, I'll try and find time to get it found.

    If you upgrade to RC2a, you can have it immediately ;)

    Comment by Gary — February 12, 2008 @ 2:00 pm


  5. can i do that with a templated version?? as i tell you what i'd love to do it right away lol :P

    Comment by misery_kitty — February 13, 2008 @ 4:20 pm


  6. I tried ur script. Unfortunately… it doesnt display the coupon code details and also doesnot apply the discount to the total on the confirm_payment page… ??? can u plz tell me what is wrong…

    Comment by Jenson — February 15, 2008 @ 11:18 pm


  7. this looks really neat, my brain nearly exploded with the other complex ones

    Comment by sasha — February 16, 2008 @ 4:53 am


  8. Jenson - if it does not work, then most likely you have installed it incorrectly. Maybe missed adding some code, or did not set up the order_total correctly in your Admin section? Start Over ;)

    Sasha - thanks :)

    Comment by Gary — February 16, 2008 @ 8:54 am


  9. I have checked it with ms2, and I am sad to say that it is not working. First of all the discount does not show on the confirmation page. I noticed that even in the video this is the case, only after you click on payment method and confirm it again the coupon shows. Well this was not the case with my ms2 version, it did not show at all. Furthermore I tried to place another order right after I used the coupon for the first one. And for some strange reason I wasnt able to fill in a coupon number due to the fact that it said I already used one for that order. While in fact I did not use one for that order but the previous one.

    Comment by Bert — February 16, 2008 @ 3:45 pm


  10. It's not for MS2 ;)

    Comment by Gary — February 16, 2008 @ 5:19 pm


  11. Good spot onthe "not showing discount in confirmation" though - I had missed that :(

    All you need to do is remove the block of code from lines 85 to 106 inclusive of checkout_confirmation.php and move it to ABOVE the line of code that is;

    require(DIR_WS_CLASSES . 'order_total.php');

    Doh! No point calling the discount after the order_total. Good spot, thanks.

    Comment by Gary — February 16, 2008 @ 5:41 pm


  12. And I also forgot a whole file - which is the cause of the other error. I'll get a new package uploaded tonight sometime ;)

    Comment by Gary — February 16, 2008 @ 6:13 pm


  13. Even though it might not be for MS2 I still noticed the fact that in the video the discount did not show the first time you showed the confirmation page. Is it some kind of bug in the system or intentionally put there?

    Comment by Bert — February 16, 2008 @ 6:19 pm


  14. Bert - yes, I forgot a file and made a mistake in 1 other file. I'll repackage the fixes and upload. I might even port to MS2 at the same time.

    Comment by Gary — February 16, 2008 @ 11:26 pm


  15. […] admin on Gift Vouchers RC1 and RC2 […]

    Pingback by Club osCommerce » Version 1.1 of Discount Coupons and Gift Vouchers for RC osCommerce — February 17, 2008 @ 11:33 am


  16. Now fixed both errors - please download at http://addons.oscommerce.com/info/5743

    Any and all support/discussion is welcome on this blog post.

    Comment by Gary — February 17, 2008 @ 11:35 am


  17. Hi!

    I'm interested in this. There are two other contributions with similar names, CCGV(trad) and Credit Class & Gift Voucher, which alters the Osc core files quite extensively, which is not good, how about this one? Is this new contibution of yours, built on these or is it a new approach to achieve the same thing? Would you mind elaborate a bit…

    You don't happen to know whether it will play nicely together with Separate Pricing Per Customer 4.2.0 (SPPC)?

    Comment by kbking — February 17, 2008 @ 12:26 pm


  18. KBK - this is a brand new approach to get (almost) the same thing. As far as I know, my version is simpler than the others that you mention. Mine does not alter much of the core code of osCommerce - only: checkout_process.php, checkout_confirmation.php and checkout_payment.php …

    What mine does not have is a system to email customers a voucher/discount code. For me, that is pointless so I did not code it.

    I don't know if it will play nicely with SPPC - perhaps, you would post again here, if you do try it?

    Comment by Gary — February 17, 2008 @ 12:36 pm


  19. Oh, it also has a couple new functions - but nothing major.

    Comment by Gary — February 17, 2008 @ 12:37 pm


  20. Also, I'm on ms2.2 on which I've applied the patches for RC1 and planning to apply the RC2 as well. Will this be enough to use your contribution?

    TIA
    /kbking

    Comment by kbking — February 17, 2008 @ 12:40 pm


  21. KBK - should be fine. Just take it slowly and use the "already installed" folder rather than the "install on new". The "install on new" is a bunch of drop in files for someowho has just installed RC. You won't want that as you already have some contributions installed - and dropping in a new file might hurt those already installed contributions.

    In the "already installed" folder, you'll see a bunch of folder and files. Any files ending in .php are OK to just upload as they won't overwrite anything. Any files ending in .txt will need the code contained in them to be added to your pre-existing .php files of the same name. It makes sense when you see it ;)

    It might be worth you installing a clean RC2 as a test site, then installing the drop-in files so that you can test the contribution to see if it's suitable for what you need.

    Good luck!

    Comment by Gary — February 17, 2008 @ 12:46 pm


  22. Thanks for now :)

    Comment by kbking — February 17, 2008 @ 12:50 pm


  23. Hey,
    Thanks for this code, very simple to put in a very very modified osc. I have QTPRO installed and no problem with it (impossible with others big voucher's contribs).
    Just one thing for others, you have to sort order "coupon" to "0" in order total module to see reduction in action. (one hour to understand:-( ).

    Comment by gilles — February 17, 2008 @ 6:44 pm


  24. Gilles, many thanks for your feedback, I really appreciate it :)

    I'm not sure about teh sort_order having to be zero - might that be somehting that's in your shop only? I really don't know…I added a screenshot to the original post (up there^) that shows sort orders that work nicely…at least for me!

    I'll await more feedback on it, and see if anyone else has the same as you - and put it into the readme if needed.

    Thanks!
    Gary

    Comment by Gary — February 17, 2008 @ 8:38 pm


  25. bonjour,

    yeah!
    My error after different tests was to order coupon after taxe. Before taxe, there is no pb.
    —-
    Sous-Total: 16.90 €
    Colissimo direct suivi (2 kg): 7.00 €
    Coupon (5%surmacommande) -0.85 €
    TOTAL TVA: 2.77 €
    Total: 23.05 €
    ——
    I have tranlate it for a french shop. Do you want code?

    Merci, Thanks

    Comment by gilles — February 17, 2008 @ 10:05 pm


  26. Wow this is an excellent contribution. Thanks for sharing and I will use it in my shop;-)
    LĂ©onie.

    Comment by LĂ©onie — February 17, 2008 @ 10:10 pm


  27. Gilles - I would very much like your french translation - thank you. I will add it into the download on the oscommerce site. My email address is oscshops AT gmail DOT com - merci!.

    LĂ©onie - thank you very much for your feedback. Nice t-shirt site you have there.

    Comment by Gary — February 17, 2008 @ 10:13 pm


  28. I Send you a .rar with french translation and screenshot of the result

    Comment by Gilles — February 18, 2008 @ 2:06 am


  29. I would like this contribution for osCommerce 2.2-MS2?

    Comment by Mike — February 18, 2008 @ 2:14 am


  30. me again :D

    just thought i'd pop in and ask how the ms2 golden ticket is coming lol… cheers mate!! :)

    Comment by misery_kitty — February 18, 2008 @ 3:45 am


  31. Gilles - thank you very much!

    Mike & MK - I'll get around to it, need to find some free time ;)

    Comment by Gary — February 18, 2008 @ 10:56 am


  32. On the Delivery Page, when I click on Continue, I get this error on the next page:

    1146 - Table 'western_oscommerce.TABLE_COUPONS' doesn't exist

    select count(*) as total from TABLE_COUPONS where coupon_status = '1'

    [TEP STOP]

    I have this display order:
    1 - Sub Total
    2 - Coupon
    3 - Shipping
    4 - Total

    The table coupons and coupon_to_customer exist. The coupons table also has the
    information in it.

    Thanks for your help.

    Comment by Craig — February 18, 2008 @ 8:01 pm


  33. Hi,
    I recently installed this add-on which I can't wait to use as I think it is great!
    However when on my oscommerce, at the top of every page I recieve this error…
    Warning: session_start() [function.session-start]: Cannot send session cookie - headers already sent by (output started at /includes/database_tables.php:133)

    AND… I can't acces my admin control at all I just recieve this…

    Warning: session_start() [function.session-start]: Cannot send session cookie - headers already sent by (output started at /admin/includes/filenames.php:70)

    WHAT CAN I DO???

    Thanks for all help in advance…
    Joey

    Comment by Joey — February 18, 2008 @ 8:55 pm


  34. From the Delivery Information page, when I select Continue, I get the following error:
    1146 - Table 'western_oscommerce.TABLE_COUPONS' doesn't exist

    select count(*) as total from TABLE_COUPONS where coupon_status = '1'

    [TEP STOP]

    The table coupons does exist.

    Any help would be greatly appreciated.

    Comment by Craig — February 18, 2008 @ 9:16 pm


  35. I love this.
    Seeing such a thing is one the moments when I wish I had become a programmer…
    it´s exactly what I was looking for.

    Cheers

    Comment by Joachim — February 18, 2008 @ 9:47 pm


  36. Well I would need the version for RC1…
    thanks

    Comment by Joachim — February 18, 2008 @ 9:52 pm


  37. Craig - you need to make sure that you have added the name of the database table to the file admin/includes/database_tables.php

    Joey - you have made a common mistake. Make sure that you have no blank lines or spaces after the final ?> or before the first <? of includes/database_tables.php and admin/includes/filenames.php

    Joachim - so go download it and install it ;)

    Comment by Gary — February 18, 2008 @ 10:41 pm


  38. It is in the first line I believe:

    Comment by Craig — February 18, 2008 @ 11:04 pm


  39. <?php
    define{'TABLE_COUPONS', 'coupons'};
    /*
    $Id: $

    Comment by Craig — February 18, 2008 @ 11:07 pm


  40. If that's the first line of your file, it won't work. Should be

    define('TABLE_COUPONS', 'coupons');

    — remove the curly brackets.

    Comment by Gary — February 18, 2008 @ 11:10 pm


  41. My mistake, the first line is as you said it should be, they are ( ), not { }. But still have the error.

    Comment by Craig — February 18, 2008 @ 11:56 pm


  42. Just wanted to let you know that I got it working. I uninstalled and started fresh. I guess I missed somethiong before.

    Now that it is working, it was worth it. It is working great! Thanks.

    Comment by Craig — February 19, 2008 @ 12:43 am


  43. I was wondering if the wording "Discount Coupon" on the Payment Information page can be
    changed to "Member Discount".

    Thanks.

    Comment by Craig — February 19, 2008 @ 3:53 am


  44. Craig - good work :) You can change the wording in the language files -> /includes/languages/checkout_payment.php

    Comment by Gary — February 19, 2008 @ 8:29 am


  45. Unfortunately after getting rid of all spaces between these files I am still getting the following errors at the top of every page on oscommere:
    Warning: session_start() [function.session-start]: Cannot send session cookie - headers already sent by (output started at x/catalog/includes/database_tables.php:58) in x/catalog/includes/functions/sessions.php on line 102

    Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at x/catalog/includes/database_tables.php:58) in x/catalog/includes/functions/sessions.php on line 102

    AND, in the admin panel, which is still in-accessable…

    Warning: session_start() [function.session-start]: Cannot send session cookie - headers already sent by (output started at x/admin/includes/database_tables.php:49) in x/admin/includes/functions/sessions.php on line 102

    Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at x/admin/includes/database_tables.php:49) in x/admin/includes/functions/sessions.php on line 102

    Warning: Cannot modify header information - headers already sent by (output started at x/admin/includes/database_tables.php:49) in x/admin/includes/functions/general.php on line 40

    Can anyone help…
    Thanks a lot again!!
    Joey

    Comment by Joey — February 19, 2008 @ 9:43 am


  46. Fixed the problem now but when I log into my admin control I get the following error now…
    Should I just do the same and delete all spaces??

    Comment by Joey — February 19, 2008 @ 9:54 am


  47. Yes I've fixed that one now but now have :

    Parse error: syntax error, unexpected '}' in /admin/includes/boxes/customers.php on line 43

    On my Admin control and it all looks a bit out of place?

    Sorry for all the questions but i'm really in a hurry to sort this out, thanks again!

    Comment by Joey — February 19, 2008 @ 10:00 am


  48. Sorry guys its ok, I fixed it myself, I think that I put it in the wrong place to start with, but for some it may be best if you word where about to put it because that section got a bit confusing. May have just been me though!
    Great add-on!!!
    Thanks again!
    Joey

    Comment by Joey — February 19, 2008 @ 10:40 am


  49. Glad you got it sorted :)

    Comment by Gary — February 19, 2008 @ 1:20 pm


  50. I thought I had it all done, but while testing, it seems that it is not changing any price. In the invoice or anyhting.
    Any reasons why this is?

    Comment by Joey — February 19, 2008 @ 2:55 pm


  51. User Error when installing, most likely ;)

    Make sure that you have set up your order_totals correctly.

    Sounds like you need 1-on-1 assistance ;)

    Comment by Gary — February 19, 2008 @ 2:57 pm


  52. Sorry my error sorted yet agin, I should look before posting here in future. :)
    Anyway as I said before a great, easy to use add-on you have here, keep up the good work!!

    Comment by Joey — February 19, 2008 @ 2:58 pm


  53. Hi

    I have installed this add-on to my oscommerce version 2.2RC2. After much testing, i have found that when a coupon is created and given to a customer to use, they can repeatedly use the coupon over & over, even when the coupon has been deleted, set to 'once' or turned-off! After the customer has entered the coupon code, they can make repeated orders with the same coupons discount. At the 'checkout_payment' page, it reads 'A coupon has already been applied to this order'. At the 'checkout_confirmation' page, the discount is applied, even if the coupon has already been used, set to once, switched-off or deleted! Has anyone else experienced this same problem? Please help as to how to fix this.

    Thanks, Brad

    Comment by Brad — February 19, 2008 @ 7:41 pm


  54. Joey - good work, glad you got there in the end.

    Comment by Gary — February 19, 2008 @ 8:41 pm


  55. Brad - I just tested this and cannot duplicate your findings. I tried this on RC2 (a brnad new install) with my GV/dc contrib applied on top.

    Can you send me your store URL and a coupon code - to my email address: oscshops AT gmail DOT com

    Thanks.

    Comment by Gary — February 19, 2008 @ 8:43 pm


  56. is this working for non RC1 version?the earlier one?

    Comment by tanicos — February 20, 2008 @ 2:43 am


  57. At this moment, it's for RC1, RC2, RC2a only.

    Comment by Gary — February 20, 2008 @ 9:52 am


  58. Im afriad my site is not currently live. I have checked the install over 3 times and everythhing is exactly as it should be. Do you need to have any php functions activated?

    Comment by Brad — February 20, 2008 @ 1:35 pm


  59. Nope, should work right out the box if everything is installed (and configured) correctly.

    Can't help any more without trying it live on your server.

    Comment by Gary — February 20, 2008 @ 1:54 pm


  60. I think i found the problem…i have been testing the add-on by confirming the order with PayPal IPN, and obviously not actually paying. Therefore the order never fully completes so the add-on thinks that the order is still on-going; hence why the coupon discount always stayed! I assumed as the order was placed as it showed in the back-admin. Does this make sense to you? Is the code set up to dispose of the coupon after the checkout_success page has been displayed?

    Thanks, Brad

    Comment by Brad — February 20, 2008 @ 4:56 pm


  61. Brad - good thinking. The coupon is destroyed when the buyer hits "checkout_process.php" - obviously depending upon whether the coupon is a "once" or a "multiple" will determine whether they can use it again. Try setting up "cash on delivery" and see if you can recreate the error using that particular payment method.

    Comment by Gary — February 20, 2008 @ 5:07 pm


  62. Success - testing with 'cash on delivery' now fully works. But do you know if the customer is returned to checkout_success after they have paid with PayPal IPN? Im not sure as i have never paid for something on my own site!

    Comment by Brad — February 20, 2008 @ 6:18 pm


  63. WOW you are a busy boy admin!! lol… osc help/contributions are sniffed out and swarmed these days lol :) that is all ….thought i'd comment on the great work you're …always nice to hear i feel :D

    Comment by misery_kitty — February 21, 2008 @ 3:11 am


  64. Brad - yes, the main order processing page is checkout_process.php and (as far as I am aware) ALL orders are passed through it at some stage.

    MK - thanks :)

    Comment by Gary — February 21, 2008 @ 10:52 am


  65. […] admin on Gift Vouchers RC1 and RC2 […]

    Pingback by Club osCommerce » Version 1.2 of Discount Coupons and Gift Vouchers for RC osCommerce — February 21, 2008 @ 1:07 pm


  66. TAXPROBLEM!

    Great mod but i have a tax-problem:
    1 - Sub Total: 200 Euro
    2 - Coupon: -20 Euro
    3 - Shipping: 0.00 Euro (Free)
    4 - Tax 19%: 38.00 Euro
    5 - Total: 218 Euro

    It has to be:
    1 - Sub Total: 200 Euro
    2 - Coupon: -20 Euro
    3 - Shipping: 0.00 Euro (Free)
    4 - Tax 19%: 34.20 Euro
    5 - Total: 214.20 Euro

    How to fix? Thanks!

    Comment by mike — February 21, 2008 @ 1:43 pm


  67. Hi, I'm just wondering if the coupon ties to a particular customer ID, or it can be used by any customer? Is it possible to make the coupon options can be set to:
    (1) be used by one or all customers;
    (2) restricted on some items or no item restrictions;
    (3) requires minimum order total or no minimum;
    (4) has expiration or no expiration.

    If your contrib can do those, it will be great. Thanks.

    Comment by taf — February 21, 2008 @ 5:37 pm


  68. Mike; my understanding is that a GV must be applied at the end price (otherwise you will be showing tax problems). Thus:

    Product: 200
    Tax @ 19%: 38
    Discount (10%): 20
    Total to Pay: 218

    Maybe in the next update I will look at the codebase for applying on the product price, after which discount is then worked out and tax applied.

    Taf; no such limits like that. Any customer can use the coupon on any product.

    Comment by Gary — February 21, 2008 @ 6:23 pm


  69. Hey, yes it´s me again…

    Ehm I was just wondering, and
    think it would be a good idea
    to make it visible in the
    administration-area if a coupon
    has been used or even ensure,
    that it would "turn off" itselves´
    state of activity because that would be so handy to keep order…
    Ok just an idea…

    Comment by Joachim — February 21, 2008 @ 11:31 pm


  70. Hi,
    This contribution looks great. Just want I am looking for. I was wondering if you have the MS2 (for osCommerce 2.2-MS2) version ready yet.
    thanks
    girl

    Comment by girl — February 22, 2008 @ 5:18 am


  71. Joachim - that's a good idea - but whether you select "once" or multiple", the coupon never runs out. Once is once per customer, not just once in total.

    It would be quite easy to make a new page showing the uses of the coupons. Maybe in the next update.

    Girl - MS2 version is not yet started.

    Comment by Gary — February 22, 2008 @ 9:38 am


  72. This looks like a great contribution. Thank you!

    Unfortunately, I am having some difficulty with it: I've tried it on a v2.2RC2a local store I'm working on. I never see the coupon amount deducted from the total but the next time I do a purchase it tells me that the coupon has been used. I'm looking at your screenshot and I do not have 'Coupon' listed as an item in my Order Total. What did I miss?

    Thanks much!

    Comment by Francisco — February 22, 2008 @ 10:15 am


  73. Francisco; make sure that you have uploaded the file;

    /includes/modules/order_total/ot_coupon.php

    Comment by Gary — February 22, 2008 @ 10:22 am


  74. Hi,
    I've installed the contrib, and have it showing on the checkout_shipping.php page. Its using FEC with AJAX total update. However is not picking up the couplon discount. Any help would be greatly appreciated.

    Thanks
    Alan

    Comment by Alan — February 22, 2008 @ 12:28 pm


  75. FEC (Fast Easy Checkout for those no in the know ;)) is a contribution that makes the checkout process a bit less long.

    Alan - FEC makes too many changes to the core code - in other words, it's poorly coded in relation to the osCommerce Code standards. What version of osCommerce are you using?

    Comment by Gary — February 22, 2008 @ 12:34 pm


  76. I'm using R2 I think. Can't see where to says it. Is it possable you could sort it out. Can you email me to discuss?

    Comment by Alan — February 22, 2008 @ 12:48 pm


  77. Hey ,

    this looks great but is it available for MS2

    Paul

    Comment by Tearitup — February 22, 2008 @ 7:28 pm


  78. Thanks Gary! Uploading /includes/modules/order_total/ot_coupon.php did the trick!

    I have an additional question: any thoughts on how I can complete the transaction while skipping going to PayPal IPN if the total amount (after the coupon) equals zero?

    Much appreciated!!

    Comment by Francisco — February 22, 2008 @ 8:32 pm


  79. Paul; RC1, RC2, RC2a at this moment. I might try to get around to making a MS2 version sooner rather than later.

    Francisco; I think this is not possible - have you had a hunt in the osCommerce Forum? Try "bypass paypal if payment amount zero" (or something like that).

    Comment by Gary — February 22, 2008 @ 8:39 pm


  80. I was afraid of that Gary. Yes, I have searched quite a bit in the forums but will do more. Thanks for your prompt reply!

    Comment by Francisco — February 22, 2008 @ 8:51 pm


  81. A quick hunt in Google brought me this link: http://www.activeebiz.com/bypass-payment-page-p-29.html

    But it does cost money, and I have no idea if it'll work in your situation.

    Comment by Gary — February 22, 2008 @ 9:20 pm


  82. Hmmmn. Thinking about it…

    The Coupon shows in the payment page - so you'd have to move that to a different page. Easy enough ;)

    Then if the cart total is zero, skip the payment page.

    Then if the cart total is zero, don't show the payment info on the checkout_confirmation page

    Then if the cart total is zero, make the button on checkout_confirmation go directly to checkout_process.php

    It's quite a lot of work, but I think it is do-able.

    Comment by Gary — February 22, 2008 @ 9:27 pm


  83. Thanks for the good input Gary! I did find a "Free Of Charge Payment Module" contribution that would work great but it does it's check before one has the chance to apply the coupon. So if the amount is zero to begin with, the Free of Charge option shows up at payment time. I'm going through the code to see if I can identify where to change the order that the module kicks in. Any words of wisdom would be appreciated. Thanks much!

    Comment by Francisco — February 23, 2008 @ 1:57 am


  84. Francisco - if I can find a bit of time over the next few days, I'll see if I can't come up with something. It'd make an interesting project!

    Comment by Gary — February 23, 2008 @ 8:29 am


  85. That would be outstanding Gary!!

    Comment by Francisco — February 23, 2008 @ 10:16 am


  86. Hey,

    Thanks , or is it better to upgrade to RC 2.
    Is that hard to do.

    Paul

    Comment by Tearitup — February 23, 2008 @ 12:09 pm


  87. Paul - that depends upon how many contributions you have installed. If you have not done much with your Ms2, you would probably find it fairly easy to upgrade to RC2a.

    Or you can wait and I might find time to make a MS2 version.

    Comment by Gary — February 23, 2008 @ 6:00 pm


  88. I just installed the coupon contribution. Everything seems to be working fine until i get to the checkout_confirmation.php page. It is not displaying the coupon or the discount? I went through the entire process again and double checked all of the code with the "install on brand new osc" code. Everything is identical. Does anyone have any ideas or suggestions?

    Comment by MCousin — February 23, 2008 @ 7:03 pm


  89. Hey whats up?

    my wife and i have installed your contribution, and been trying to work it in for the past 3 days, everything seem ok, just the last page order confirmation doesnt apply the coupon amount or show it, tried reviewing the code many times, and still nothing.
    could it be that since we have the seperate canadian tax line contribution installed its not working? but the amount should still apply right?

    Comment by Kevin — February 23, 2008 @ 7:40 pm


  90. I just realized what i did wrong. I needed to specify the sort order in the "orders total" within the admin section.

    Everything is working great now!

    Comment by MCousin — February 23, 2008 @ 8:26 pm


  91. Mike - good work.

    Kevin - have a look at Mikes last post.

    Comment by Gary — February 23, 2008 @ 9:59 pm


  92. On the Payment Information page, when an invalid coupon code is entered, at the top it
    says "You have entered an invalid coupon". Can this wording be changed? (I would like it
    to say "You have entered an invalid Member number".)

    Comment by Craig — February 23, 2008 @ 10:56 pm


  93. Craig - you know those "language" files that are a part of the contribution… ;)

    Comment by Gary — February 23, 2008 @ 11:24 pm


  94. Yes, I've looked at various ones, but I cannot find the line to change.

    Comment by Craig — February 23, 2008 @ 11:49 pm


  95. Found it, thanks.

    Comment by Craig — February 24, 2008 @ 12:38 am


  96. Craig - good work. I knew you'd find it if given a prompt.

    Comment by Gary — February 24, 2008 @ 12:09 pm


  97. sorry, this comes up

    1054 - Unknown column 'p.products_subimage1' in 'field list'

    select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, p.products_subimage1, p.products_subimage2, p.products_subimage3, p.products_subimage4, p.products_subimage5, p.products_subimage6, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from products p, products_description pd where p.products_status = '1' and p.products_id = '28' and pd.products_id = p.products_id and pd.language_id = '1'

    what can I do to get it to work?

    Comment by Michelle — February 25, 2008 @ 3:24 pm


  98. Hello Michelle - this error has nothing to do with the DC GV Contribution.

    Has your friend tried to install some type of "extra images" contribution?

    Comment by Gary — February 25, 2008 @ 4:18 pm


  99. Before he installed it, we have had morepics 6 running with OSC 2.2 - can that be the problem and how do I solve it?

    Comment by Michelle — February 25, 2008 @ 5:39 pm


  100. Get your friend to re-install ;)

    Comment by Gary — February 25, 2008 @ 8:00 pm


  101. Thanks for taking time to make a MS 2.2 version,

    Is it also possible to add a percentage discount coupon instead of an amount coupon?
    So a total of 10% etc. discount on the total of the next order amount.

    Cheers,

    Paul

    Comment by Tearitup — February 26, 2008 @ 7:33 pm


  102. Paul - you can do % or fixed already.

    Comment by Gary — February 26, 2008 @ 7:37 pm


  103. okay , great,

    Paul

    Comment by Tearitup — February 27, 2008 @ 6:32 pm


  104. Burt.. looking forward to the MS 2.2 version :)

    Many thanks to you..

    Comment by Alexander — February 28, 2008 @ 1:51 am


  105. Text automatically translated from Italian

    I have installed your contribution … Excellent work compliments!
    One problem with taxes
    Application by:
    Sub-Total: € 30.00 EUR
    Coupon (provabis) - € 3.00 EUR
    PaccoCelere3 (price): € 9.10 EUR
    Taxes 20% VAT: € 6.00 EUR
    Total: € 42.10 EUR

    The fee should be:
    Sub-Total: € 30.00 EUR
    Coupon (provabis) - € 3.00 EUR
    $ 27.00
    Taxes 20% VAT: € 5.40EUR

    How can I fix?

    There is the possibility to exclude a category from discount coupons?
    Thanks for all the replies
    Sub-Totale: € 30.00 EUR
    Coupon (provabis) -€ 3.00 EUR
    27.00 EUR
    Tasse IVA 20%: € 5.40EUR

    Come posso risolvere?

    Esiste la possibilitĂ  di escludere una categoria dal discount coupon?
    Grazie per le eventuali risposte

    Comment by Valdez — February 28, 2008 @ 7:04 am


  106. Alexander - soon ;)

    Valdez - this has already been covered, read the comments :) "There is the possibility to exclude a category from discount coupons?" - no.

    Comment by Gary — February 28, 2008 @ 11:20 am


  107. Text automatically translated from Italian

    Admin Thanks for the answer.
    I saw earlier remarks and I revived the question why
    Legigislazione the Italian plans to pay taxes in this way
    Sub-Total: € 30.00
    Coupon (provabis) - € 3.00
    € 27.00
    Taxes 20% VAT: € 5.40
    Total € 32.40

    Is there a solution?

    Comment by Valdez — February 28, 2008 @ 1:00 pm


  108. Valdez - "Is there a solution?" - not yet ;)

    Comment by Gary — February 28, 2008 @ 2:14 pm


  109. Hi there,

    having a problem, in the admin section it is showing as " . BOX_TOOLS_COUPONS . " .

    Obviously that link isnt working, but when i copy the hyper, this is what is copying - tep_href_link(FILENAME_COUPONS)

    any ideas?

    many thanks :)

    Comment by Sunny — February 28, 2008 @ 4:25 pm


  110. Sunny - looks like you didn't realise that the code needs to go INSIDE the brackets of the $contents[] array…it's probably not too clear in the instructions.

    Just upload the file admin/includes/boxes/customers.php to overwrite what you already have.

    Comment by Gary — February 28, 2008 @ 4:47 pm


  111. thanks Admin, but still got a problem.

    There is no 'Coupon' option in the admin section

    Comment by Sunny — February 28, 2008 @ 4:51 pm


  112. Sunny - you have not followed the full instructions and so now you have some problems. Start again.

    Comment by Gary — February 28, 2008 @ 4:59 pm


  113. yeah im gonna have to, thanks for the help!

    ive got one more issue with my oscommerce, not a problem but something i need help on, is it ok if i email u?

    Comment by Sunny — February 28, 2008 @ 5:03 pm


  114. Sure - nut please note that I answer on the blog, not by email. Like this; http://www.clubosc.com/paypal-payment-but-no-order.html

    Comment by Gary — February 28, 2008 @ 5:05 pm


  115. How is the Ms2 version coming?

    Comment by Matthew — February 28, 2008 @ 6:37 pm


  116. hi again monkey with a cocktail lol… will you announce when you get the MS2 version going? I hate sounding like a sook :|

    .. just thought i'd ask so i dont have to keep asking lol.. saves you some sanity :P

    i tell you what you have some fans going now… you need to hire lil monkeys with lil red hats to get back to everyone lol ;)

    Comment by Misery_Kitty — February 29, 2008 @ 5:00 am


  117. Soon, soon ;)

    Comment by Gary — February 29, 2008 @ 8:36 am


  118. Hi

    It only took me 13 mins to get it installed and working all ok.

    try it!!!!

    Comment by simon — March 2, 2008 @ 11:48 pm


  119. Simon - well done.

    Comment by Gary — March 3, 2008 @ 8:41 am


  120. I am using PayPal IPN, but the discount is not being passed to paypal. Discount appears on the confirmation page.

    Comment by Ed — March 4, 2008 @ 4:58 am


  121. Ed - does it work with other payment methods? And which version of IPN are you using?

    Comment by Gary — March 4, 2008 @ 8:11 am


  122. Hi,

    Having tried many credit/voucher contribs over the years, this one finally seems like the right one. But with a heavily modded MS2 codebase (no file left untouched) I'm dreading upgrading the entire shop.

    I'm happy to port this back to MS2 but would just like to know a summary of where you expect this code to clash with MS2. I have never looked at RC code so have no clue how different it may be.

    PS Used to live in Surbiton too :)

    Comment by Johan — March 4, 2008 @ 10:05 am


  123. Hi Johan - I suspect that the code clash will be in the admin section only. I'm trying to find time to port it back, but it's difficult as "real clients" have to come first - you know how it is!

    Cheers, Gary

    Comment by Gary — March 4, 2008 @ 10:28 am


  124. I have just installed DC GV on MS2-060817 and it installed without any problems! I'm surprised at that.

    I followed the instructions in the "shop already installed" folder very carefully - and it all appears to work as it should do!

    Comment by Gary — March 4, 2008 @ 10:54 am


  125. Great, will give that a go then, cheers!

    Comment by Johan — March 4, 2008 @ 11:08 am


  126. Johan - please do let us know how the install went…

    Comment by Gary — March 4, 2008 @ 2:20 pm


  127. hiya again :P so you telling us if we follow the directions under shop already installed properly we can use this mod on ms2?? ooow excited… cant wait as this is the last mod i want to install so i can go live… ooowww!!

    Comment by Misery_Kitty — March 5, 2008 @ 5:01 am


  128. Well…it worked for me without any problem, using version 1.2 of the download (the latest one). Let us know how you get on.

    Comment by Gary — March 5, 2008 @ 8:14 am


  129. Hi,

    trying to install on a MS2, and get this error when clicking on 'Coupons' in admin.

    1054 - Unknown column 'coupon_status' in 'field list'

    select coupon_id, coupon_code, coupon_status, coupon_type, coupon_amount, coupon_use from coupons limit 0, 20

    Any idea ?

    regards
    jarzom

    Comment by jarzom — March 7, 2008 @ 7:05 am


  130. Hahahaha, installed the table in wrong data-base.

    Sorry !

    hahahaha

    Comment by jarzom — March 7, 2008 @ 7:07 am


  131. Jarzom - doh! ;)

    Comment by Gary — March 7, 2008 @ 8:26 am


  132. Thanks for this contribution. It was pretty easy to install, and works great. Unfortunately, I've just realized that I apparently can't use it with Paypal express checkout because it ends at checkout_payment.php, before the coupon is applied.

    Do you know if there's a way I can get it to work? Or can I just not use express checkout?
    Thank you

    Comment by Heather — March 8, 2008 @ 3:59 pm


  133. Would it be possible to enter the coupon code at checkout_shipping.php instead?

    Comment by Heather — March 8, 2008 @ 4:06 pm


  134. Heather - probably a fair bit of work for you to move the code to another page, but I see no reason why it would not work if you got it all correct…

    Comment by Gary — March 8, 2008 @ 4:54 pm


  135. I have a question about the checkout_payment.php file. Where do I insert the code that was provided by this mod. It doesn't say exactly where to add this code. I must be missing something. Any help appreciated…..

    Comment by David — March 9, 2008 @ 12:00 am


  136. David - anywhere you like in that file so long as it's in the "body" section ;) Have a look at the supplied checkout_payment.php file to see where I put it…

    Cheers, Gary

    Comment by Gary — March 9, 2008 @ 9:52 am


  137. hmmm, I was hoping you might have an "easier" answer…I don't know php enough to mess with it much. Thank you, though.

    Comment by Heather — March 10, 2008 @ 4:13 pm


  138. Hi,

    I just finished installing your coupon module and LOVE it. It took about a day to install. Mainly because of an unfinished/failed attempt to install another "Discount Coupon Module".

    I am using v2.2 RC1 with UPS Shipping Module installed. I had an issue with sending the discount over to the PayPal_IPN module but found if you set the Transaction Type to "AGGREGATE" it works fine.

    Comment by Isaac G. — March 10, 2008 @ 8:06 pm


  139. Isaac - thank you very much for your feedback - and thank you for the tip on setting Paypal to Aggregate :)

    Comment by Gary — March 10, 2008 @ 8:20 pm


  140. Hi,

    I was just seeing if there is a known I could try in order to get "Coupons" to show up in my OsCommerce v2.2 RC2 admin section please.

    Thanks,
    Ron

    Comment by Ron — March 11, 2008 @ 8:34 am


  141. Isaac,

    how did you adjust the paypal to aggregate? through their site or in Garys' Voucher code??

    thanks,
    ron

    Comment by Ron — March 11, 2008 @ 8:48 am


  142. Hi Gary,

    this is Ron again. I compared files for customer.php in the two folders you have for "new install" and "old install" and found the problem. Thanks again.

    I still would like a better understanding of how to change transaction for Paypal to an Aggregate please.

    Ron

    Comment by Ron — March 11, 2008 @ 9:15 am


  143. Ron - good work on comparing those files - it's the easiest way to see any problems…

    The Paypal aggregate setting, is I think, in the Paypal Module itself. If you go your Admin, then to your Paypal payment module and edit it, you should find a selection of r "aggregate".

    Cheers, Gary

    Comment by Gary — March 11, 2008 @ 9:19 am


  144. Hi folks,

    my english is not as well as i needed it for understanding this whole site, so please sorry if i've misunderstood something.

    I want to install your conrib into an existing MS2.2 shop and it would be very helpful to know, if your version is working there or if (and when :-) you'll make a special contrib for 22.

    This contrib is looking very nice and there are a lot of other voucher- contribs full of bad code…

    Thanks
    Tom

    Comment by Tom — March 11, 2008 @ 1:26 pm


  145. Tom - your english is much better than my german :D

    This should be OK for MS2 - I have tested it personally in MS2-060817 and it worked fine.

    Comment by Gary — March 11, 2008 @ 1:30 pm


  146. Heather - there is an easier way - you can pay me to do it ;)

    Unfortunately what you want is a fair bit of work and these free contributions are really a "one size fits all" deal.

    If that size doesn't fit you, then you need a bit of bespoke tailoring…hope that makes sense? Gary

    Comment by Gary — March 11, 2008 @ 1:51 pm


  147. Hi again,

    i tried out some configs in between and now its working very fine. My problem wasnt in a code, i just did not set the sort order of the module to 0 like gilles found out.
    When you install it in the admin area, its in the order 1 by default and then it does not show the amount in the checkout area.

    Its working with MS22 if - like you said - you use the "shop already installed" version of the setup wich is no problem and done very fast at all.

    You've done a great work with this, perhaps you could write this sort problem into the readme.txt and then its perfect for MS22 users to.

    Best Regards
    Tom

    Comment by Tom — March 12, 2008 @ 10:42 am


  148. Hi,

    I installed the contribution on my ocs just now. I am having only one difficulty as I am not to sure how to use the SQL file.

    I am getting this error

    1146 - Table 'eoinhea_ladylike.coupons' doesn't exist

    select count(*) as total from coupons

    Any advice on how I run the file, Step by step would be great! ;)

    Thanks you in advance,

    Eoin

    Comment by Eoin — March 12, 2008 @ 4:42 pm


  149. Eoin - no problem - see http://www.clubosc.com/how-to-use-phpmyadmin-to-load-sql.html

    Tom - thanks for the feedback :)

    Comment by Gary — March 12, 2008 @ 5:37 pm


  150. That seems to have done the trick.

    I now have a different problem:

    I can enter a coupon code in the checkout but it is not deducting the value from the order.

    Any ideas?

    Comment by Eoin — March 12, 2008 @ 7:09 pm


  151. Sorry to bother you again,

    but just noticed that the Coupon option is not there.

    Maybe this has something to do with the problem?

    :(

    Comment by Eoin — March 12, 2008 @ 7:46 pm


  152. Eoin - you have not followed the instructions 100%. Start over.

    Comment by Gary — March 12, 2008 @ 8:01 pm


  153. It's ok, I fixed it.

    When uploading ot_coupon.php there must have been an interuption somewhere.

    I noticed the file size was very small so i uploaded it again and it works just fine now.

    Thanks for your time anyway, much appreciated :-)

    Eoin

    Comment by Eoin — March 12, 2008 @ 8:11 pm


  154. Cool! :)

    Comment by Gary — March 12, 2008 @ 8:11 pm


  155. Cheers on an amazing contribution. I am really impressed with how you built your code on the OS Commerce core and simplicity. In contrast to some similar modules, you only two tables — fantastic. Works great — loaded on my website with some modifications. I think the other modules attempt to get too fancy rather than making sure the basics work. Thanks again.

    Comment by Avi Sujeeth — March 13, 2008 @ 7:42 am


  156. Avi - thank you for your feedback. Very appreciated :)

    Comment by Gary — March 13, 2008 @ 8:01 am


  157. Hi there your Gift Vouchers RC1 and RC2 module very good. However there is one thing that i am facing which is when a customer of mine did a purchase a copy of the purchase was not notify or send to his mailing address.However i do receive the notification or email that he has make a purchase in my web mail.

    Before i install this Gift Vouchers i do not face this problem i suspect that i could type wrongly in some of the files.

    Could you kindly help me by advising where the problem will lies. Could it be the files checkout_confirmation.php.

    I am really can you help! Thanks!

    Comment by Teo — March 14, 2008 @ 3:57 am


  158. Teo - there's only a few files you'd need to check. The best idea is for you to go over them again, making sure to make any code changes as carefully as possible.

    Good luck - Gary

    Comment by Gary — March 14, 2008 @ 9:33 am


  159. Hi, where can I download ? Thanks . . .!

    Comment by Adrián — March 15, 2008 @ 6:23 am


  160. Adrián - http://addons.oscommerce.com/info/5743

    Comment by Gary — March 15, 2008 @ 10:05 am


  161. Great add on. Had some issues but like you said just keep trying. Read this blog
    and found all the answers I needed. Wanted to make a comment that my coupon works
    when customer clicks Paypal and checks out (Using Paypal Express Payments and OSC rc2a)
    though so don't know if that will help Heather.(Also, I only tested in sandbox, haven't
    gone live yet!)

    Kudos to you! Thanks a for a great site too btw! Learned a lot from you and I
    didn't know anything before I started a week ago.

    Comment by Amy — March 17, 2008 @ 10:10 pm


  162. Amy - thank you so much for your feedback :D

    Comment by Gary — March 17, 2008 @ 10:21 pm


  163. Hi Gary,

    I'm using PayPal IPN v2.3.3 with a RC2a store. I've read and re-read the posts and tweaked my settings accordingly but I can not get the discounted amount to go to PayPal. Each time the total (without the coupon discount) goes over. I wonder if there is code that should go on the paypal_ipn.php file.

    Thanks!

    Comment by Francisco — March 18, 2008 @ 7:44 am


  164. BTW, I do have the transaction type set as "Aggregate" for PayPal. Also I have the Order Total set: Sub-total (1), Coupon (2), Shipping(3),Tax(4) and Total(5). Anything obvious I'm missing?

    Comment by Francisco — March 18, 2008 @ 7:51 am


  165. Hi Francisco - the problem is that the Paypal IPN 2.3.3 that you are using is a poorly coded piece of crap that doesn't stick to osCommerce coding rules! I will try to find time to correct the code errors in the 2.3.3 code.

    You could take a look yourself - the problem is with the way that the "amount" (to pay) is worked out (2.3.3 version is working it out completely incorrectly!)…

    Cheers, Gary

    Comment by Gary — March 18, 2008 @ 8:48 am


  166. I'm sorry to hear this Gary. Do you have any advice for me? Is there an IPN version you think is better?

    Thanks!

    Comment by Francisco — March 18, 2008 @ 3:07 pm


  167. Francisco - have a try with this module, which is a direct replacement for what you are already using, in /includes/modules/

    Zip link

    I make no guarantees that this will work, but it certainly looks better than the coding mistakes that are already in there! Test it out 100% to your satisfaction before using it in a live shop!

    Comment by Gary — March 18, 2008 @ 3:12 pm


  168. Thanks Gary! I'll give it a go and will let you know what I find out.

    Francisco

    Comment by Francisco — March 18, 2008 @ 4:49 pm


  169. Interim testing update:

    (1)paypal_ipn.php [v2.3.3] passes total amount (w/o deducting coupon) to paypal
    (2)paypal_ipn.php [Gary's replacement] takes the coupon amount from the total but adds shipping twice before sending to paypal.

    Thoughts?

    Comment by Francisco — March 18, 2008 @ 6:10 pm


  170. Francisco - in my version, try changing all instances of;

    $order->info['total']

    to

    $order->info['total'] - $order->info['shipping_cost']

    Comment by Gary — March 18, 2008 @ 8:10 pm


  171. This seemed to do the trick Gary. Outstanding!! Thank you so much!!!!

    Comment by Francisco — March 18, 2008 @ 10:12 pm


  172. Francisco - thanks :) I updated the .zip with that change. If anyone else downloads it, I would highly suggest to fully test it out before using it in a Live Shop!

    Comment by Gary — March 19, 2008 @ 8:23 am


  173. Hi Gary,
    what a great contribution, it seems to be a very easy solution!
    I only have 1 Question: How do I make sure the Voucher gets deducted from the total? All else seems to work fine, but the amount does not get deducted. The rest (amount of vouchers/creating voucher/etc) works.
    My osc isr 2.2 RC1.

    I would really appreciate your help, Gary.

    Thank you in advance!
    Frank

    Comment by Frank — March 19, 2008 @ 10:42 am


  174. Frank - you need to specify the sort order in the "orders total" within the admin section. See the image at the bottom of the original blog post (up there ^)…Gary

    Comment by Gary — March 19, 2008 @ 10:50 am


  175. I've a problem: discount isn't removed from order total… checkout confirmation says:

    Discount coupon (abcefg): -0.00 … but i set it to be fixed amount 10 Swiss francs.

    I use fast Easy Checkout, and I applied all checkout_payment modifications to checkout_shipping.php … I use osc MS2060817

    Comment by Luca — March 19, 2008 @ 2:15 pm


  176. Luca - "I use fast Easy Checkout"

    There's your problem - FEC makes too many changes to the core code of osCommerce. However, I suspect that parts of the coupon functionality can be recoded to deal with the FEC codebase. But that's something that will certianly not come cheaply - if you are interested please get in touch.

    Gary

    Comment by Gary — March 19, 2008 @ 5:21 pm


  177. Just need a hint where to look … get this when the browser goes to checkout_process.php. It is identical to the new version in your files.

    1366 - Incorrect decimal value: " for column 'value' at row 1

    insert into orders_total (orders_id, title, text, value, class, sort_order) values ('4', 'Coupon (uflorida)', '-$1.50', ", 'ot_coupon', '3')

    [TEP STOP]

    Comment by Craig — March 20, 2008 @ 8:00 pm


  178. Craig - for some reason your codebase is not transferring the correct "value". Could be for any number of reasons, hard to say without seeing your live codebase - for which I would charge appropriately (in other words, don't post a load of code here as that'll do no good) - it needs further in depth investigation. I'd just start afresh if I were you.

    Comment by Gary — March 20, 2008 @ 8:11 pm


  179. Harmonie - it works with MS2 - just make sure to follow the installation instructions closely, and if you run into trouble refer to the "install on brand new" instructions to see wht you have done wrong.

    Comment by Gary — March 21, 2008 @ 9:30 am


  180. Thanks Amy
    Maybe we're not using the same payment module? I'm using the "PayPal Website Payments Pro U.S." mod which includes Express that comes with OSC. There is no way for the coupon to be applied as the page where the code is entered is as far as one can go when checking out with Express, thus the coupon doesn't get entered…..

    Maybe I just need to choose another Paypal mod? It's confusing, as there are 3 that come with OSC, and tons more on the mod site. Why are there so many, anyway? sigh….

    Comment by Heather Perkins — March 25, 2008 @ 2:28 pm


  181. hey,

    I spent over 3 hours with 'another' voucher contribution before finding out it doesn't work with v2.2 RC2a.
    Yours took 15 mins to install and after I remembered to set the coupon sort order to 0 it worked a treat.

    Thanks loads.

    Comment by Pleased Boy — March 28, 2008 @ 1:34 am


  182. Need some confirmation here.. I am using :
    osCommerce 2.2 - MS2, PHP 5.0.4, MySQL 5.0.15-nt

    Is it ok? already installed at test site. However, get this in Admin –> Coupons:

    1064 - You have an error in your SQL syntax;
    select count(*) as total from coupons limit -20, 20;

    These coupon should apply to certain product or ..?

    Can u help me? TQ.

    Comment by mama — March 28, 2008 @ 3:44 am


  183. Pleased Boy - many thanks for the feedback :) The whole point of what I am trying to do with osCommerce these days is to make everything as simple as possible. I think that a lot of coders "overcook" things…

    Mama - http://forums.oscommerce.com/index.php?showtopic=144095

    Comment by Gary — March 28, 2008 @ 8:16 am


  184. after i install it, the admin workds, when i place the order works, the when i checkout, the discount is not applied, dont know why that happend, can someone help me?

    Regards

    Comment by Kendo Rosario — March 29, 2008 @ 3:33 am


  185. Kenod Rosario - you have not followed the instructions 100%. Most likely you have not set the coupon sort order in your admin area. If you have, then just start over, and if that does not work, see this post.

    Comment by Gary — March 29, 2008 @ 8:50 am


  186. hi Gary,
    thanx for the good work, respect! i have a question: i need a german language file, do you have one? or do you know where can i get one?

    Thanx and greetings from berlin-germany

    Comment by Eso — March 29, 2008 @ 10:42 am


  187. Hey Eso - to fix this up, take the whole /includes/languages/english/ folder of the contribution and rename the folder to "german". Upload! Then do the same for the Admin section…

    Then you'll have a lot of english words witin your german section, so you'll need to translate them and change the appropriate english words to german words.

    It's not difficult - just takes a bit of time. If you do translate the files, please send them to me at shop AT oscbooks DOT com and I will add them to the contribution. Thanks.

    If you cannot manage to get it working with German, I can help, please see here - I would have to use Babelfish to make the translations though.

    Gary

    Comment by Gary — March 29, 2008 @ 10:48 am


  188. Hey Gary,
    it's a wonderfull idea, thanx. why i get not self to this way? i dont know… :-). Of course, when i take the time and will be finished with the german translation i will send it to you! thats the way how it works with free contribs i think!

    greets E

    Comment by Eso — March 29, 2008 @ 12:39 pm


  189. Hello Gary,
    its me again. the german language problem i have done, an in the moment it looks good. but i have a generaly problem with the video.

    by the start of the video you klicked in the admin site of the left menue on the 4th link from top, it calld by me "customers". Then the 3rd link of this category is in the video "Coupons". By me the last link is "orders". Do you understand me, there is no link "coupons" the create one…

    have you got a idea why?

    thanks…

    Comment by Eso — March 29, 2008 @ 1:39 pm


  190. Eso - it's because you haven't followed the instructions ;)

    Take a look at the code for the "install on brand new" folder - particularly the files; admin / includes / boxes/ customers.php - and compare it to what you have live in your server…you might see a difference..

    Comment by Gary — March 29, 2008 @ 4:02 pm


  191. well, looks like i dont found in the .txt where say that i need to change order of coupons :S

    reading this post i found the answer :)

    Thanks the contrib works OK.

    Comment by Rosario Kendo — March 29, 2008 @ 4:27 pm


  192. Hey RK - no worries - now you got it sorted :)

    For anyone else in the future having trouble seeing the instructions, it's in the "Usage" section of the readme.txt

    Comment by Gary — March 29, 2008 @ 5:52 pm


  193. Hi Gary,

    Thanks for the contribution. For the online shop, yes it works. Great!!

    However for the admin site, actually I've done those modification before, but it didn't work for me. Never mind, for the time being, I can manually alter the database.

    TQ so much for your work!!

    Comment by mama — March 31, 2008 @ 2:07 am


  194. I have to say that this is one of the better thought out Contributions that I have worked with.

    I like the approach to minimizing the impact to existing code and only ran into the trouble with the sort order until I came over here.

    Very well done and thank you. I love the simplicity in the design.

    Comment by Jerry V. — March 31, 2008 @ 3:59 am


  195. Mama - you should be able to fix that problem up easily - make some more investigations in the forum about it and you might find the answer. If youy wanted me to fix it I can, but I would charge you to do so.

    Jerry V - thanks :)

    Comment by Gary — March 31, 2008 @ 8:23 am


  196. hey man… m working on a site for a computer shop… my oscommerce version is v2.2rc2a…
    i used ur latest solution for vouchers coupons…. but the problem is that i am not getting any error now… but when i finally checkout to process the order it refreshes to the first page again… and nth else happens… can u tell me y???
    i m using paypal direct and express payments… its urgent and necessary…
    waiting for reply… if u can mail me the solution thats will be more fine…

    Comment by assad nazar — April 1, 2008 @ 7:19 am


  197. Assad - start again, or see here for installation service.

    Comment by Gary — April 1, 2008 @ 8:45 am


  198. Works a treat, great work. I went down the shop already install route for this install, the only small problem was putting the code in the right place in catalog/checkout_payment.php as i found out it needed to go under

    at about line 317
    if the code is put anywhere else on this page the coupon shows up at the bottom of the payment page and not the middle.
    Other than that this is a great mod. Thankyou for your time and effort.

    Comment by TechHead — April 5, 2008 @ 8:47 am


  199. Thanks TechHead :)

    Comment by Gary — April 5, 2008 @ 9:57 am


  200. Awesome job! It would be good that when the coupon is applied to the order, the shopping cart total is automatically recalculated and displayed. From your demo, it looks like the client has to double-check that the gift cert was applied and for what amount.

    Comment by Felisa — April 5, 2008 @ 4:49 pm


  201. Felisa - the coupon is applied and is seen on the "confirmation screen"…the demo is a bit outdated ;)

    Comment by Gary — April 6, 2008 @ 10:46 am


  202. Hi Gary,

    It's me again. Just to say that everything work for me. Just now I am on my way to modify it little bit so that it will meet my requirement.

    Is it possible that only selected item get the discount, and also the discount is apply to all quantity for item A.

    Example: Only item A get 20% discount, and if the customer buy 3 item A, each item A he will get 20% discount.

    Any suggestion where should I start? Thanks..

    Comment by mama — April 8, 2008 @ 8:44 am


  203. Mama - what you need is quite complicated. It's certainly possible.

    My thought would be to have all the "allowed" products in an array - then check the customer cart to see if any of the products in his cart are also in the array. If yes, place the discount against the products that are in both.

    See what you can come up with. I can take a look at coding something for you, but it'll be expensive…

    Comment by Gary — April 8, 2008 @ 9:05 am


  204. Is it possible to make coupons only re-deamable on orders over a set minimum order value?

    Look forward to any replys

    Comment by DR — April 8, 2008 @ 10:58 pm


  205. DR - yes it is, but not as part of the base code of the contribution. You'd just need to amend the checkout_payment.php page to only show the coupon input if the cart_total > X … It's not a lot of work. Good luck!

    If you want me to quote you for this, email me on oscshops@gmail.com

    Gary

    Comment by Gary — April 9, 2008 @ 8:57 am


  206. Hi, just downloaded the coupon voucher. One question though.

    IN the Catalog/checkout_payment txt file you have the following code, but it doesnt tell me where in the checkout_payment.php it needs to go? Can you help? thanks Joe

    Comment by Joe Perkowski — April 9, 2008 @ 7:29 pm


  207. Joe - compare that file to the file that is inside the "install on brand new" - ;)

    If you have troubles, I have an installation service.

    Cheers, Gary

    Comment by Gary — April 9, 2008 @ 7:48 pm


  208. Gary,

    Thanks for the post for help. One question more. We got v2.2RC1. Will your contrib work with it? Cause the Voucher/Coupon selection isnt coming up. If it does Ill have to reinstall it to make sure I got all the changes made.

    Thanks

    Joe

    Comment by Joe Perkowski — April 9, 2008 @ 8:35 pm


  209. Joe - it does work with RC1.

    Comment by Gary — April 9, 2008 @ 9:35 pm


  210. Nice contribution. Wish I could use it. After installing and realizing I'm not using RC1 nor RC2 I spent the next day and a half upgrading my site only to find out that this contribution does not work with a previos contribution I installed, namely Fast Easy Checkout (http://www.oscommerce.com/community/contributions,3469).

    Can anyone help me and tell me how I can get these two excellent contribution to work with each other.

    Thanks
    Steve

    Comment by Steve Cranson — April 10, 2008 @ 1:21 am


  211. Steve - FEC makes too many changes to the core code of osCommerce. However, I suspect that parts of the coupon functionality can be recoded to deal with the FEC codebase. But that's something that will certainly not come cheaply - if you are interested please get in touch. Gary

    Comment by Gary — April 10, 2008 @ 8:44 am


  212. Hi Gary
    Installed this on RC2a under wamp. Works and easy
    install.
    Wondering if you plan to generate the coupon
    code automatically in the future.

    Also, any advice about using the GV part of the addon?

    Comment by Leslie Cooper aka Coopco — April 13, 2008 @ 1:13 pm


  213. Coopco - the GV part is more than likely to be a paid upgrade (when I get around to coding it). Automatic coupon codes would be part of that.

    Comment by Gary — April 14, 2008 @ 9:23 am


  214. Gary,
    V2.2 rc2. installed your formula in a new OS then I get this
    error
    Fatal error: Cannot redeclare class soapclient in /home/saspreci/public_html/Amadeo/includes/classes/nusoap.php on line 7239

    Any rescuing Idea,

    Deo

    Comment by Dep — April 17, 2008 @ 4:06 am


  215. Deo - nusoap class is not a standard part of osCommerce and is definitely not in my contribution. Start over?

    Comment by Gary — April 17, 2008 @ 12:27 pm


  216. I am interested in this,
    not sure which version of OsCommerce I am using.
    I think its an older version around 2005.

    Can you please send it to me

    Comment by Shane — April 21, 2008 @ 6:59 am


  217. Shane - you can download it and install yourself